Repository navigation
Fix generated OpenAPI contracts - #802
Merged
Merged
Conversation
byronellis
added this pull request to stack #803
October 4, 2026 21:48
byronellis
marked this pull request as ready for review
October 5, 2026 04:09
mkuchenbecker
approved these changes
Oct 5, 2026
mkuchenbecker
left a comment
mkuchenbecker
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, other than making sure we don't document that null=table.
These two tasks should fall on the view and lock projects that are in-flight. I think those projects should ultimately be responsible going forward. If we are seeing more of these issues that block I want to make sure these issues are caught by the build.
teamurko
approved these changes
Oct 5, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
byronellis
force-pushed
the
byellis/housetables-openapi-entity-type
branch
from
October 6, 2026 05:08
e628585 to
07000b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue with openapi generation introduced in PR 737 I believe. It was preventing me from doing a full test cycle, but I believe this PR should fix it. Putting it at the top of my stack for a quick merge.
Changes
For all the boxes checked, please include additional details of the changes made in this pull request.
Testing Done
For all the boxes checked, include a detailed description of the testing done for the changes made in this pull request.
The thing that broke was the testing itself so the fact that they now pass is was acceptance criteria. In future people should probably run tests before merging to avoid breaking other people.
Additional Information
For all the boxes checked, include additional details of the changes made in this pull request.